Hi @farodin91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

Are you sure

extraArgs:
        - --extraArgABool
        - --extraArgBBool

Does not work? The project supports

--ignore-ingress-tls-spec
--no-ignore-ingress-tls-spec

Pull Request Test Coverage Report for Build 22539991316

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.005%) to 79.278%

Totals
Change from base Build 22526174103:	-0.005%
Covered Lines:	16080
Relevant Lines:	20283

💛 - Coveralls

@ivankatliarchuk I'm a bit confused. i should remove the whitespace.

I added a tests with does it in the expected way: https://github.com/kubernetes-sigs/external-dns/pull/6179/changes#diff-bc73335a2fc76673f78676b9284eba373396c0efb1dcca92a3d96c416c756685R175

This feature is currently supported. You could try

      extraArgs:
        --combine-fqdn-annotation:
        --no-expose-internal-ipv6:

The proposed solution not too sure, seems redundant

If this is what we want

  - it: should allow 'extraArgs' with boolean flags
    set:
      extraArgs:
        --combine-fqdn-annotation
        --no-expose-internal-ipv6

    asserts:
      - equal:
          path: spec.template.spec.containers[?(@.name == "external-dns")].args
          value:
            - --log-level=info
            - --log-format=text
            - --interval=1m
            - --source=service
            - --source=ingress
            - --policy=upsert-only
            - --registry=txt
            - --provider=aws
            - --combine-fqdn-annotation
            - --no-expose-internal-ipv6

What is required

    156 +            {{- if kindIs "string" .Values.extraArgs }}
      157 +            {{- range (splitList " " .Values.extraArgs) }}
      158 +            {{- if . }}
      159 +            - {{ tpl . $ }}
      160 +            {{- end }}
      161 +            {{- end }}
      162 +            {{- end }}

But this will not allow map, or slices to be added.

Something like this, if we have mix of values

extraArgs:
  extraArgA: valueA
  combine-fqdn-annotation:
  no-expose-internal-ipv6:

Or

  - it: should allow 'extraArgs' with mix of flags with and without values
    set:
      extraArgs:
      - --extraArgA=valueA
      - --combine-fqdn-annotation
      - --no-expose-internal-ipv6

    asserts:
      - equal:
          path: spec.template.spec.containers[?(@.name == "external-dns")].args
          value:
            - --log-level=info
            - --log-format=text
            - --interval=1m
            - --source=service
            - --source=ingress
            - --policy=upsert-only
            - --registry=txt
            - --provider=aws
            - --combine-fqdn-annotation
            - --extraArgA=valueA
            - --no-expose-internal-ipv6

file values.yml most likely need a commented out example with mix of flags, and schema to support string for extraArgs

I want to add the bool variant, as this allows me to override it with different value in a values.yaml file. This isn't straightforward with an array, and I don't like the idea of unsetting.

Example with values.yaml and values.prod.yaml:
values.yaml

extraArgs:
  dev-arg: true

values.prod.yaml

extraArgs:
  dev-arg: false

helm template prod . -f values.prod.yaml

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from stevehipwell. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

/lgtm

Fixes #6261

@ivankatliarchuk Anything to do?

Nope. We are w8 for an approver

@stevehipwell Any Update?